Bug fix: reconcile a "create" change with a new extension map.#574
Merged
Bug fix: reconcile a "create" change with a new extension map.#574
Conversation
… minifying the source service extensions.
a42f621 to
796ca94
Compare
chriswalker
approved these changes
Jun 17, 2021
Contributor
chriswalker
left a comment
There was a problem hiding this comment.
Obviously lacking a fair bit of context on the code at the moment, but LGTM based on conversation in standup, and test changes all look good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #573
Bug summary
During reconciliation, the base docker compose extensions map used to detect changes was mistakenly mutated.
This was not an issue if a single environment override was being reconciled.
But, it definitely was a problem if multiple environment overrides were reconciled at once as the first reconcile breaks the following reconcile.
Bug fix