Conversation
… build strategy with CNB
ezodude
reviewed
May 27, 2021
Contributor
ezodude
left a comment
There was a problem hiding this comment.
Looks good so far. Left 2 small comments.
…ort for build strategy with CNB
…ort for build strategy with CNB
…ort for build strategy with CNB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #537
This PR slightly modifies the way Skaffold build artifacts are detected, and as a result strategy used to build them.
By default a
local docker buildstrategy is used, unless no Dockerfile has been detected and docker compose manifest (application stack representation) references docker images with a build context - this suggest that artefact build should still go ahead, however, as there is no Dockerfile present it should use CNB to do the build.