Skip to content

Derive environment override file name from kev manifest file name. #384

Merged
marcinc merged 2 commits intomasterfrom
derive-env-file-extension-from-kev-manifest-name
Feb 18, 2021
Merged

Derive environment override file name from kev manifest file name. #384
marcinc merged 2 commits intomasterfrom
derive-env-file-extension-from-kev-manifest-name

Conversation

@marcinc
Copy link
Member

@marcinc marcinc commented Feb 18, 2021

Resolves: #383

This PR modifies how the environment overrides are named. The suffix is now extracted from the ManifestName rather than being fixed.

@marcinc marcinc requested a review from ezodude February 18, 2021 10:34
Copy link
Contributor

@ezodude ezodude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but the general gist is correct.

@marcinc marcinc requested a review from ezodude February 18, 2021 11:12
Copy link
Contributor

@ezodude ezodude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcinc marcinc merged commit a40f389 into master Feb 18, 2021
@marcinc marcinc deleted the derive-env-file-extension-from-kev-manifest-name branch February 18, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Derive environment override file name suffix from the ManifestName

2 participants