Bug #749 flow stats: avoid overstating flow packet count#765
Merged
Conversation
Flow, fps, flow packet counts make sense for many combinations of packet
modifiers and cache settings:
```
# tcpreplay -i enp0s5 -l1 --mbps=1 ping.pcap
Actual: 16 packets (1568 bytes) sent in 0.012564 seconds
Rated: 124801.0 Bps, 0.998 Mbps, 1273.47 pps
Flows: 2 flows, 159.18 fps, 16 unique flow packets, 0 unique non-flow packets
Statistics for network device: enp0s5
Successful packets: 16
Failed packets: 0
Truncated packets: 0
Retried packets (ENOBUFS): 0
Retried packets (EAGAIN): 0
# tcpreplay -i enp0s5 -l1 --mbps=1 -K ping.pcap
File Cache is enabled
Actual: 16 packets (1568 bytes) sent in 0.012561 seconds
Rated: 124830.8 Bps, 0.998 Mbps, 1273.78 pps
Flows: 2 flows, 159.22 fps, 16 unique flow packets, 0 unique non-flow packets
Statistics for network device: enp0s5
Successful packets: 16
Failed packets: 0
Truncated packets: 0
Retried packets (ENOBUFS): 0
Retried packets (EAGAIN): 0
# tcpreplay -i enp0s5 -l10 --mbps=1 ping.pcap
Actual: 160 packets (15680 bytes) sent in 0.125452 seconds
Rated: 124988.0 Bps, 0.999 Mbps, 1275.38 pps
Flows: 2 flows, 15.94 fps, 160 unique flow packets, 0 unique non-flow packets
Statistics for network device: enp0s5
Successful packets: 160
Failed packets: 0
Truncated packets: 0
Retried packets (ENOBUFS): 0
Retried packets (EAGAIN): 0
# tcpreplay -i enp0s5 -l10 --mbps=1 -K ping.pcap
File Cache is enabled
Actual: 160 packets (15680 bytes) sent in 0.125451 seconds
Rated: 124989.0 Bps, 0.999 Mbps, 1275.39 pps
Flows: 2 flows, 15.94 fps, 16 unique flow packets, 0 unique non-flow packets
Statistics for network device: enp0s5
Successful packets: 160
Failed packets: 0
Truncated packets: 0
Retried packets (ENOBUFS): 0
Retried packets (EAGAIN): 0
# tcpreplay -i enp0s5 -l10 --mbps=1 --unique-ip --unique-ip-loops=3 ping.pcap
Actual: 160 packets (15680 bytes) sent in 0.125451 seconds
Rated: 124989.0 Bps, 0.999 Mbps, 1275.39 pps
Flows: 20 flows, 159.42 fps, 160 unique flow packets, 0 unique non-flow packets
Statistics for network device: enp0s5
Successful packets: 160
Failed packets: 0
Truncated packets: 0
Retried packets (ENOBUFS): 0
Retried packets (EAGAIN): 0
# tcpreplay -i enp0s5 -l10 --mbps=1 --unique-ip --unique-ip-loops=3 -K ping.pcap
File Cache is enabled
Actual: 160 packets (15680 bytes) sent in 0.125457 seconds
Rated: 124983.0 Bps, 0.999 Mbps, 1275.33 pps
Flows: 20 flows, 159.41 fps, 160 unique flow packets, 0 unique non-flow packets
Statistics for network device: enp0s5
Successful packets: 160
Failed packets: 0
Truncated packets: 0
Retried packets (ENOBUFS): 0
Retried packets (EAGAIN): 0
# tcpreplay -i enp0s5 -l10 --mbps=1 --unique-ip --unique-ip-loops=3 ping.pcap
Actual: 160 packets (15680 bytes) sent in 0.125456 seconds
Rated: 124984.0 Bps, 0.999 Mbps, 1275.34 pps
Flows: 8 flows, 63.76 fps, 64 unique flow packets, 0 unique non-flow packets
Statistics for network device: enp0s5
Successful packets: 160
Failed packets: 0
Truncated packets: 0
Retried packets (ENOBUFS): 0
Retried packets (EAGAIN): 0
# tcpreplay -i enp0s5 -l10 --mbps=1 --unique-ip --unique-ip-loops=3 -K ping.pcap
File Cache is enabled
Actual: 160 packets (15680 bytes) sent in 0.125450 seconds
Rated: 124990.0 Bps, 0.999 Mbps, 1275.40 pps
Flows: 8 flows, 63.77 fps, 64 unique flow packets, 0 unique non-flow packets
Statistics for network device: enp0s5
Successful packets: 160
Failed packets: 0
Truncated packets: 0
Retried packets (ENOBUFS): 0
Retried packets (EAGAIN): 0
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flow, fps, flow packet counts make sense for many combinations of packet modifiers and cache settings: