Merged
Conversation
Depending on compilaiton flags, UNUSED() was declaring variables with different names. Meaning the following can be either expanded to: UNUSED(var) -> var UNUSED(var) -> UNUSED_var __attribute__((unused)) depending on the compilation flags. The code using such a variable would need to also be conditional to the same compilation flags ... and that's to heavy. Let's declare variables by the name they are given instead. UNUSED(var) -> var /* with/without the attribute, but always "var" */ Fixes appneta#612 Signed-off-by: Gabriel Ganne <gabriel.ganne@gmail.com>
fklassen
approved these changes
Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on compilaiton flags, UNUSED() was declaring variables with
different names.
Meaning the following can be either expanded to:
UNUSED(var)->varUNUSED(var)->UNUSED_var __attribute__((unused))depending on the compilation flags.
The code using such a variable would need to also be conditional to the
same compilation flags ... and that's to heavy.
Let's declare variables by the name they are given instead.
UNUSED(var)->var/* with/without the attribute, but always "var" */Fixes #612
Signed-off-by: Gabriel Ganne gabriel.ganne@gmail.com