Merged
Conversation
Those are mostly parameters being only used with netmap
rename somme comments from "no break" to "fallthrough" in order to silence gcc where needed
tcpedit_tcpedit_optDesc_p is defined within the *.def files, the variable itself is defined in the generated C files.
b1de6de to
a53c1ea
Compare
Member
|
Thanks for the PR @GabrielGanne. I will include it in the next fix release, coming shortly. |
Member
I got a tip from Debian guys to try As usual, thanks for the help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
In my setup, this leaves two warning:
A
cast-function-typewarnings caused by libpcapIn my opinion, the code calling libpcap is valid, and the warning can safely be ignored.
Another saying that the <sys/sysctl.h> header is deprecated and will be removed.
I'll just leave the warning for later.
Best regards,