Merged
Conversation
Those are mostly parameters being only used with netmap
rename somme comments from "no break" to "fallthrough" in order to silence gcc where needed
Member
|
@GabrielGanne thanks for the PR. I will merge as part of next point release. BTW, if you are interested in becoming a maintainer and contributing directly to the repo, please contact me at tcpreplay at appneta dot com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is to silence some warnings that appeared when I migrated from debian 9 -> 10 which comes with gcc 8.3 (over 6.3).
It addresses implicit fallthrough and unused function parameter warnings.
This does not cover them all: there are for example still warnings in makeshell.c's text_to_var() function, because gcc does not understand the NOTREACHED comments (which I find quite explicit). I did not find it a good idea to change those.
Best regards,