Merged
Conversation
get_ipv6_next() returns NULL on malformed packets. If that happens return the last proto that could be read. This should fix issue appneta#537
get_ipv6_next() returns NULL on malformed packets. If that happens return the last header that could be read. This should fix issue appneta#536
Member
|
@GabrielGanne thanks for the PR. I am rebasing into a branch for test, documentations, changelog and versioning. |
This was referenced Mar 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Those are fix proposal for issues #536 and #537.
However, the #356 reproducer is in big endian for some reason, and when working on little endian, it fails to load because the read capture length is bigger than the maximum.
However both issues really look the same to me and the fixes are localized, so I'm confident about my proposal.
Please review.
Best regards