Do not put example service name into the dashboard config#84
Merged
kukushechkin merged 2 commits intoapple:mainfrom Jan 14, 2026
Merged
Conversation
czechboy0
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove swift-system-metrics ServiceIntegration example name from the example dashboard provisioning.
Motivation:
With the specific service name hardcoded in the dashboard provisioning config, it is not compatible with other projects where people might want to just copy-paste this config. All other metrics (CPU%, fds) already use values across all the reported dimensions.
Modifications:
Removed
service_name="ServiceIntegrationExample"filter from the memory consumption dashboard visualization.Result:
Memory dashboard configuration no longer shows memory usage only for the
ServiceIntegrationExampleservice. Any project adoptingSystemMetricsMonitorcan now copy-paste the config as-is and get the Process System Metrics dashboard configured automatically in their Grafana.