Implements a metrics provider for Darwin#78
Merged
kukushechkin merged 6 commits intoapple:mainfrom Dec 19, 2025
Merged
Conversation
Closed
Contributor
|
@barrytomasini Thanks for taking the time to work on this! |
Contributor
|
I think we can go with this macOS-specific implementation — add |
0f39deb to
484f07e
Compare
Contributor
Author
|
Thanks, @kukushechkin! I've restored the warning for non-macOS Darwin platforms, added a note to the doc comment, and restored the platform checks in the shared test cases. Let me know if anything else needs to be updated! |
kukushechkin
requested changes
Dec 19, 2025
Contributor
kukushechkin
left a comment
There was a problem hiding this comment.
One linter error left
kukushechkin
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch adds a Darwin metrics provider, using macOS system APIs.
Motivation:
Someone developing or deploying a service on macOS should be able to take advantage of the same system metrics that are available to Swift processes running on Linux. (#72)
Modifications:
nilResult:
Feature parity between macOS and Linux for collecting system metrics.