Fix flaky testCopyFileReplacingExistingFileSucceeds#3554
Merged
fabianfett merged 4 commits intoapple:mainfrom Mar 18, 2026
Merged
Fix flaky testCopyFileReplacingExistingFileSucceeds#3554fabianfett merged 4 commits intoapple:mainfrom
fabianfett merged 4 commits intoapple:mainfrom
Conversation
Member
Author
|
Sadly I wasn't able to reproduce the flaky tests on my machine. So this fix is a best guess. |
glbrntt
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
testCopyFileReplacingExistingFileSucceeds(andtestCopySymlinkReplacingExistingSymlinkSucceeds) verify that no .tmp- prefixed files are left behind after acopyItem(replaceExisting: true)call on Linux. However, both tests create their files in the shared system temp directory (e.g. /tmp) and then scan that entire directory for .tmp- files. When other tests run in parallel, their in-flightcopyItem(replaceExisting: true)operations leave transient .tmp- files in the same directory, causing spurious failures.Changes
addTeardownBlockto ensure the subdirectory is removed even if the test fails early.Results
The temp file assertions are no longer affected by concurrent test activity or other processes writing to the shared temp directory, eliminating the flakiness.