Fix flakey testHalfCloseOwnOutputWithPopulatedBuffer on iOS sim#3551
Merged
rnro merged 1 commit intoapple:mainfrom Mar 17, 2026
Merged
Fix flakey testHalfCloseOwnOutputWithPopulatedBuffer on iOS sim#3551rnro merged 1 commit intoapple:mainfrom
testHalfCloseOwnOutputWithPopulatedBuffer on iOS sim#3551rnro merged 1 commit intoapple:mainfrom
Conversation
Motivation * `testHalfCloseOwnOutputWithPopulatedBuffer` asserts that writing to a half-closed channel produces `ChannelError.outputClosed`. However, after flushing the buffered write and the FIN, the remote peer can process both and fully close the connection before the subsequent write is processed. When this happens the channel is fully closed and the write fails with `.ioOnClosedChannel` instead. This race seems to be more likely on iOS simulators. Modifications * Accept either `.outputClosed` or `.ioOnClosedChannel` as valid errors from the post-half-close write. Result * The test no longer flakes on iOS simulator CI runs.
Lukasa
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
testHalfCloseOwnOutputWithPopulatedBufferasserts that writing to a half-closed channel producesChannelError.outputClosed. However, after flushing the buffered write and the FIN, the remote peer can process both and fully close the connection before the subsequent write is processed. When this happens the channel is fully closed and the write fails with.ioOnClosedChannelinstead.Modifications
.outputClosedor.ioOnClosedChannelas valid errors from the post-half-close write.Result