Fix flakey testScheduledCallbackNotExecutedBeforeDeadline#3550
Merged
rnro merged 2 commits intoapple:mainfrom Mar 16, 2026
Merged
Fix flakey testScheduledCallbackNotExecutedBeforeDeadline#3550rnro merged 2 commits intoapple:mainfrom
testScheduledCallbackNotExecutedBeforeDeadline#3550rnro merged 2 commits intoapple:mainfrom
Conversation
Motivation * `MTELGScheduledCallbackTests.testScheduledCallbackNotExecutedBeforeDeadline` is flakey on macOS CI. It schedules a callback with a 1ms deadline, sleeps for 1µs via `Task.sleep`, then asserts the callback hasn't fired. On a loaded CI runner, `Task.sleep` can overshoot well past 1ms, causing the callback to fire before the assertion. Modifications * Increase the scheduled callback deadline from `.milliseconds(1)` to `.hours(1)` in `_BaseScheduledCallbackTests`. This makes it impossible for the short sleep to overshoot past the deadline. The `EmbeddedEventLoop` and `NIOAsyncTestingEventLoop` subclasses use virtual time so this change is harmless to them. Result * The test reliably asserts that a callback is not executed before its deadline without depending on real-time sleep precision.
glbrntt
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MTELGScheduledCallbackTests.testScheduledCallbackNotExecutedBeforeDeadlineis flakey on macOS CI. It schedules a callback with a 1ms deadline, sleeps for 1µs viaTask.sleep, then asserts the callback hasn't fired. On a loaded CI runner,Task.sleepcan overshoot well past 1ms, causing the callback to fire before the assertion.Modifications
.milliseconds(1)to.hours(1)in_BaseScheduledCallbackTests. This makes it impossible for the short sleep to overshoot past the deadline. TheEmbeddedEventLoopandNIOAsyncTestingEventLoopsubclasses use virtual time so this change is harmless to them.Result