Replace Task.sleep(for:) with Task.sleep(nanoseconds:) in `EventL…#3548
Merged
rnro merged 1 commit intoapple:mainfrom Mar 12, 2026
Merged
Replace Task.sleep(for:) with Task.sleep(nanoseconds:) in `EventL…#3548rnro merged 1 commit intoapple:mainfrom
Task.sleep(for:) with Task.sleep(nanoseconds:) in `EventL…#3548rnro merged 1 commit intoapple:mainfrom
Conversation
…oopTest` Motivation * `Task.sleep(for:)` and the `Duration` literals (`.milliseconds`, `.seconds`) require iOS 16.0+, tvOS 16.0+, and watchOS 9.0+, so these calls cause build failures on simulator test destinations in CI. Modifications * Replaced all five `Task.sleep(for:)` calls in `EventLoopTest.swift` with the universally available `Task.sleep(nanoseconds:)`. Result * `EventLoopTest` compiles for iOS, tvOS, and watchOS simulator destinations. Verified locally with `xcodebuild build-for-testing`.
FranzBusch
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…oopTest`
Motivation
Task.sleep(for:)and theDurationliterals (.milliseconds,.seconds) require iOS 16.0+, tvOS 16.0+, and watchOS 9.0+, so these calls cause build failures on simulator test destinations in CI.Modifications
Task.sleep(for:)calls inEventLoopTest.swiftwith the universally availableTask.sleep(nanoseconds:).Result
EventLoopTestcompiles for iOS, tvOS, and watchOS simulator destinations. Verified locally withxcodebuild build-for-testing.