Remove .timeLimit from EventLoopTest Swift Testing attributes#3545
Merged
rnro merged 1 commit intoapple:mainfrom Mar 11, 2026
Merged
Remove .timeLimit from EventLoopTest Swift Testing attributes#3545rnro merged 1 commit intoapple:mainfrom
.timeLimit from EventLoopTest Swift Testing attributes#3545rnro merged 1 commit intoapple:mainfrom
Conversation
Motivation * `.timeLimit` from Swift Testing requires iOS 16.0+, watchOS 9.0+, and tvOS 16.0+, but the package's deployment targets are lower, causing build failures on all iOS/watchOS/tvOS simulator test steps in CI. Modifications * Removed `.timeLimit(.minutes(1))` from the `@Suite` attribute on `MultiThreadedEventLoopGroupTests`. * Removed `.timeLimit(.minutes(1))` from the `@Test` attribute on `testRepeatedTaskThatCancelsItselfNotifiesOnlyWhenFinished`. Result * Tests compile on iOS, watchOS, and tvOS simulator destinations. The CI job timeout still guards against hung tests.
Lukasa
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
.timeLimitfrom Swift Testing requires iOS 16.0+, watchOS 9.0+, and tvOS 16.0+ causing build failures on all iOS/watchOS/tvOS simulator test steps in CI.Modifications
.timeLimit(.minutes(1))from the@Suiteattribute onMultiThreadedEventLoopGroupTests..timeLimit(.minutes(1))from the@Testattribute ontestRepeatedTaskThatCancelsItselfNotifiesOnlyWhenFinished.Result