Make MTELG's support for CPU pinning public#3543
Merged
Lukasa merged 3 commits intoapple:mainfrom Mar 9, 2026
Merged
Conversation
Motivation: NIO has had support for CPU pinning for 8 years, but nobody has ever used it. Ask me how I know? Modifications: - Make the CPU pinning constructor public. Result: Users can pin MTELG threads to specific CPU cores, _finally_.
josephnoir
approved these changes
Mar 9, 2026
fabianfett
approved these changes
Mar 9, 2026
glbrntt
requested changes
Mar 9, 2026
Sources/NIOPosix/LinuxCPUSet.swift
Outdated
| /// - arguments: | ||
| /// - pinnedCPUIds: The CPU ids to apply to the `NIOThread`s. | ||
| convenience init(pinnedCPUIds: [Int]) { | ||
| public convenience init(pinnedCPUIds: [Int]) { |
Contributor
There was a problem hiding this comment.
I think this should be pinnedCPUIDs (#fileID, NIOThread.currentThreadID and others)
glbrntt
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
NIO has had support for CPU pinning for 8 years, but nobody has ever used it. Ask me how I know?
Modifications:
Result:
Users can pin MTELG threads to specific CPU cores, finally.