Add the replaceExisting to the _NIOFileSystem copyItem#3535
Merged
glbrntt merged 10 commits intoapple:mainfrom Mar 9, 2026
Merged
Add the replaceExisting to the _NIOFileSystem copyItem#3535glbrntt merged 10 commits intoapple:mainfrom
replaceExisting to the _NIOFileSystem copyItem#3535glbrntt merged 10 commits intoapple:mainfrom
Conversation
glbrntt
reviewed
Mar 3, 2026
… implementation for the one with `replaceExisting:`
glbrntt
reviewed
Mar 5, 2026
glbrntt
approved these changes
Mar 6, 2026
Contributor
|
The nightly failures are unrelated. The API breakage is expected and okay here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the changes from #3508 to the
_NIOFileSystem.Motivation:
We have added capability to overwrite regular files and symbolic links to
NIOFSFileSystem.copyItemin #3508. Now we want to port the same logic to_NIOFileSystem.Modifications:
FileSystemProtocol.copyItemrequirement withreplaceExisting: boolparameter along with a default implementation.FileSystemProtocol.copyItemrequirement to_NIOFileSystem'sFileSystemstruct for regular files and symbolic links.Notes
It seems that the tests for
FileSystemare only inNIOFS- so no tests are added in this PR.