Scope benchmark threshold diff to Thresholds/ directory#3529
Merged
rnro merged 2 commits intoapple:mainfrom Feb 27, 2026
Merged
Scope benchmark threshold diff to Thresholds/ directory#3529rnro merged 2 commits intoapple:mainfrom
Thresholds/ directory#3529rnro merged 2 commits intoapple:mainfrom
Conversation
Motivation
* `check_benchmark_thresholds.sh` runs `git add --intent-to-add .` and
`git diff HEAD` to show updated threshold files when benchmarks regress.
* The unscoped `.` caused the diff to include everything in the working
tree, including the `.build` directory, producing noisy output.
Modifications
* Pass `${benchmark_package_path}/Thresholds/` to both
`git add --intent-to-add` and `git diff HEAD --` so only threshold
files appear in the diff.
Result
* The diff printed on benchmark failure shows only threshold file changes.
FranzBusch
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
check_benchmark_thresholds.shrunsgit add --intent-to-add .andgit diff HEADto show updated threshold files when benchmarks regress..caused the diff to include everything in the working tree, including the.builddirectory, producing noisy output.Modifications
${benchmark_package_path}/Thresholds/to bothgit add --intent-to-addandgit diff HEAD --so only threshold files appear in the diff.Result