Make concurrency take over cheaper#3527
Merged
Lukasa merged 2 commits intoapple:mainfrom Feb 27, 2026
Merged
Conversation
Motivation:
When using concurrency takeover, we currently spend nearly half the runtime
checking if our SelectableEventLoop has an enqueue function. We know it does,
but we just haven't given the compiler enough evidence. This patch rewrites
the code to prove it to the compiler.
Modifications:
- Expose internal functions without erased types on MTELG
- Use these internal functions, and call directly to SEL, eliminiating
the as!.
Result:
Massive perf improvement in task enqueueing.
FranzBusch
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
When using concurrency takeover, we currently spend nearly half the runtime checking if our SelectableEventLoop has an enqueue function. We know it does, but we just haven't given the compiler enough evidence. This patch rewrites the code to prove it to the compiler.
Modifications:
Result:
Massive perf improvement in task enqueueing.