benchmark diff missing new threshold files#3516
Merged
Lukasa merged 1 commit intoapple:mainfrom Feb 23, 2026
Merged
Conversation
Motivation * When threshold files don't exist yet, `thresholds update` creates new untracked files. `git diff HEAD` only shows changes to tracked files, so newly created threshold files were silently omitted from the diff. Modifications * Run `git add --intent-to-add .` before `git diff HEAD` so that untracked files are registered in the index and appear in the diff output without staging their contents. Result * The diff output now includes newly created threshold files.
Lukasa
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
thresholds updatecreates new untracked files.git diff HEADonly shows changes to tracked files, so newly created threshold files were silently omitted from the diff.Modifications
git add --intent-to-add .beforegit diff HEADso that untracked files are registered in the index and appear in the diff output without staging their contents.Result