Workaround test crashing when compiled in release mode on Swift 6.2#3511
Merged
simonjbeaumont merged 1 commit intoapple:mainfrom Feb 18, 2026
Merged
Conversation
rnro
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Our post-merge, pre-release pipelines run tests for our supported Swift versions in both debug and release mode. The recent PR to add
withUnsafeTransportIfAvailableadded some tests for various valid and invalid usages of the API. One of the invalid usages was causing the tests to crash, when compiled in release mode, in the Swift runtime:The test is fine for both debug and release mode on Swift 6.0, 6.1, and 6.3-nightly.
Modifications:
Since this is a valid construction and the crash is a Swift bug, and since it only manifests on a specific Swift version, and since it's only triggered when mis-using the API, we can just not perform this part of the test on Swift 6.2. The API is fully functional when used correctly.
Result:
Running NIO tests, compiled in release mode, no longer crashes on Swift 6.2.3.
Local testings:
With this branch: