Don't send (in)active when channel closes directly#3497
Merged
Lukasa merged 10 commits intoapple:mainfrom Feb 11, 2026
Merged
Conversation
Motivation: Issue apple#2773 reports a series of events where channels can receive channelInactive before channelActive. This breaks expectations and should not happen. Instead of sending them in the wrong order, this PR suppresses both of them. Modifications: * Add a test to reproduce the problematic behavior. * Add a new flag to track if channelActive was fired. * Check if the state machine is still in the active state before firing channelActive. Result: Address apple#2773.
Lukasa
reviewed
Feb 6, 2026
| case (.preActivation, .finishActivation): | ||
| self.currentState = .fullyActivated | ||
| return { promise, pipeline in | ||
| promise?.succeed(()) |
Contributor
There was a problem hiding this comment.
In cases where we expect no promises to arrive, let's just assert there isn't one.
Contributor
Author
There was a problem hiding this comment.
Yes, sounds good.
Lukasa
approved these changes
Feb 11, 2026
Contributor
Lukasa
left a comment
There was a problem hiding this comment.
Very nice, thanks @josephnoir!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Issue #2773 reports a problem where channels can receive
channelInactivebeforechannelActive. This breaks expectations and should not happen. Instead of sending them in the wrong order, this PR suppresses both of them in those cases.Modifications
channelInactivewhen originating from the state that sentchannelActive.Result
Address #2773.
Edit: Updated modifications to reflect latests commit.