Centralize UnsafeTransfer in NIOCore#3492
Merged
glbrntt merged 5 commits intoapple:mainfrom Feb 3, 2026
Merged
Conversation
Lukasa
approved these changes
Jan 23, 2026
21db1ba to
7d82c2f
Compare
cad7514 to
22fba8b
Compare
glbrntt
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a number of copies of
UnsafeTransferand two copies ofUnsafeMutableTransferBoxin our code base. Before introducing more of those, lets centralize to just one using apackageaccess modifier.