test: Port EventLoopFutureTest to Swift Testing.#3491
Merged
glbrntt merged 1 commit intoapple:mainfrom Feb 5, 2026
Merged
Conversation
weissi
reviewed
Jan 23, 2026
weissi
reviewed
Jan 23, 2026
weissi
requested changes
Jan 23, 2026
Member
weissi
left a comment
There was a problem hiding this comment.
Requesting changes because this incorrectly pulls EmbeddedEventLoop across threads and also changes .wait() to await [...].get() which is incorrect.
38a6010 to
58b6aa8
Compare
Contributor
Author
|
@weissi I believe I have addressed all concerns. Please let me know if any more changes are needed. Appreciate the great review! |
weissi
approved these changes
Jan 23, 2026
Member
weissi
left a comment
There was a problem hiding this comment.
thanks for addressing the comments.
Lukasa
approved these changes
Jan 26, 2026
auto-merge was automatically disabled
January 27, 2026 18:20
Head branch was pushed to by a user without write access
58b6aa8 to
13a64d7
Compare
Contributor
Author
|
Rebased this on the latest main. @Lukasa Looks like my rebase disabled the auto-merge, sorry. |
68 tasks
…adjustments to ensure tests are ran from the event loop.
13a64d7 to
3cb2863
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port
EventLoopFutureTestto Swift Testing. Includes some adjustments to ensure tests are ran from the event loop, among other minor changesMotivation:
Tests should use the latest Swift Testing framework when possible.
Modifications:
EventLoopFutureTestfrom XCTest to Swift TestingResult:
All tests continue to pass, EventLoopFutureTest now has more modern Swift Testing syntax.