Use explicit class name in all Self.[un]wrap{In}{Out}bound{In}{Out} calls#3463
Merged
aryan-25 merged 3 commits intoapple:mainfrom Dec 15, 2025
Merged
Use explicit class name in all Self.[un]wrap{In}{Out}bound{In}{Out} calls#3463aryan-25 merged 3 commits intoapple:mainfrom
aryan-25 merged 3 commits intoapple:mainfrom
Conversation
Lukasa
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Swift does not currently generic specialize static methods on final classes that have no parent classes when the method is implemented in a protocol. This means that calling such methods through
Selfwill not involve a generic specialization, whereas using the explicit type name will.This pattern manifests in the
[un]wrap{In}{Out}bound{In}{Out}static methods defined in theChannelInboundHandlerandChannelOutboundHandlerprotocols and their use from all channel handler classes. As such, we should replace theSelfpart in allSelf.[un]wrap{In}{Out}bound{In}{Out}calls with the explicit class name.Modifications:
Replaced all
Self.[un]wrap{In}{Out}bound{In}{Out}calls to use the explicit class name.Result:
Eliminates unnecessary overhead.