Add ByteBuffer.readableBytesUInt8Span#3458
Merged
Lukasa merged 2 commits intoapple:mainfrom Dec 5, 2025
Merged
Conversation
Lukasa
reviewed
Dec 4, 2025
| } | ||
|
|
||
| @Test | ||
| @available(macOS 26.0, iOS 26.0, watchOS 26.0, tvOS 26.0, *) |
Contributor
There was a problem hiding this comment.
Where did these availabilities come from?
Contributor
Author
There was a problem hiding this comment.
Span.bytes requires macOS 26
Contributor
There was a problem hiding this comment.
Oh, it's probably nicer to just copy-paste the implementation from the raw span side and get the lower availability.
Lukasa
approved these changes
Dec 5, 2025
Contributor
|
Thanks Adam! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ByteBuffer.readableBytesUInt8Span
Motivation:
Provide access to readableBytes as a Span
Modifications:
Added computed property
ByteBuffer.readableBytesUInt8Span. I also attempted to addByteBuffer.mutableReadableBytesUInt8Spanbut due to an apparently faulty exclusivity issue I couldn't get this to work. See swiftlang/swift#81218.Result:
You can access the readable bytes of a ByteBuffer as a Span