SelectableEventLoop.debugDescription: fix debugDescription deadlock#3360
Merged
Lukasa merged 1 commit intoapple:mainfrom Aug 28, 2025
Merged
SelectableEventLoop.debugDescription: fix debugDescription deadlock#3360Lukasa merged 1 commit intoapple:mainfrom
Lukasa merged 1 commit intoapple:mainfrom
Conversation
weissi
commented
Aug 28, 2025
| #endif | ||
|
|
||
| func testRegressionSelectableEventLoopDeadlock() throws { | ||
| let iterations = 1_000 |
Member
Author
There was a problem hiding this comment.
note to reviewers: even 10 reproes basically 100% on my machine. 1000 should be really safe
Lukasa
approved these changes
Aug 28, 2025
Contributor
|
I've been seeing this test consistently hang the Android emulator on macOS, but strangely not the emulator on linux, since it was added. As a result, I've disabled it on macOS for now, finagolfin/swift-android-sdk@7999223ba, which unblocked my daily Android CI. It might be related to how the Android emulator is run on each host OS, with Manolo noticing earlier that it is only run on one virtual core on macOS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
In #3297, I introduced a deadlock involving
SelectableEventLoop'sdebugDescription. I was under the impression that it's not possible to call this from outside theNIOmodule so I deemed it safe. That was a mistake :).Modifications:
SelectableEventLoop.debugDescription.Result: