add a CocoaPods podspec generator by weissi · Pull Request #54 · apple/swift-log

weissi · 2019-04-15T10:29:41Z

Motivation:

Users ask for a CocoaPod. Unfortunately, the CocodPod SwiftLog is
already taken, so I went for SwiftLogAPI.

Modification:

Add a podspec generator.

Result:

Happier users.
fixes CocoaPods / Carthage support #19

Example output:

Pod::Spec.new do |s|
  s.name = 'SwiftLogAPI'
  s.version = '1.0.0'
  s.license = { :type => 'Apache 2.0', :file => 'LICENSE.txt' }
  s.summary = 'A Logging API for Swift.'
  s.homepage = 'https://github.com/apple/swift-log'
  s.author = 'Apple Inc.'
  s.source = { :git => 'https://github.com/apple/swift-log.git', :tag => s.version.to_s }
  s.documentation_url = 'https://github.com/apple/swift-log'
  s.module_name = 'Logging'

  s.swift_version = '5.0'
  s.cocoapods_version = '>=1.6.0'
  s.ios.deployment_target = '12.0'
  s.osx.deployment_target = '10.14'
  s.tvos.deployment_target = '12.0'

  s.source_files = 'Sources/Logging/**/*.swift'
end

larryonoff · 2019-04-15T10:46:42Z

Please see below my feedback:

I don't see watchOS as a deployment target. Is it supported? I don't think that there're limitations to support watchOS.
What about name 'AppleSwiftLog' or 'swift-log' instead of 'SwiftLogAPI'?

weissi · 2019-04-15T10:58:44Z

Please see below my feedback:

I don't see watchOS as a deployment target. Is it supported? I don't think that there're limitations to support watchOS.

Oh thanks! Would you mind checking if it works? I have no idea how to build a Watch app :)

What about name 'AppleSwiftLog' or 'swift-log' instead of 'SwiftLogAPI'?

Could do that, or maybe SSWGSwiftLog. @tomerd / @ktoso / @ianpartridge / @tanner0101

ianpartridge · 2019-04-15T11:05:54Z

SwiftLogAPI seems fine to me - it makes it clear that this is an API package, not a backend.

ktoso · 2019-04-15T12:43:30Z

A bit unfortunate with the module name already occupied hm... SwiftLogAPI sounds fine though.
Would we care to have all API packages in both systems adopt same naming style for this?

scripts/sanity.sh

scripts/build_podspec.sh

weissi · 2019-04-16T18:44:25Z

@tanner0101 you also fine with pod name SwiftLogAPI?

Sources/Logging/Logging.swift

NOTICE.txt

ktoso

👍
(opinion on package name == neutral... people who actively use CocoaPods would have opinions / ideas I guess)

allenhumphreys · 2019-04-17T14:18:36Z

Why is the iOS/tvOS deployment target 12 and macOS 10.14? Are there any unavailable APIs in use? (I'm currently using all this source deploying to iOS 11)

In fact, I can compile all the way down to iOS 8 :-)

weissi · 2019-04-17T14:53:56Z

Why is the iOS/tvOS deployment target 12 and macOS 10.14? Are there any unavailable APIs in use? (I'm currently using all this source deploying to iOS 11)

Very happy to relax the version here if you tell me what the lowest version is that you could confirm actually working.

allenhumphreys · 2019-04-17T14:57:36Z

@weissi I'll report back shortly

allenhumphreys · 2019-04-17T15:46:48Z

@weissi Here is a git repo that has a rather large set of Apple targets. It uses a local version of the podspec with the following deployment targets:

s.ios.deployment_target = '8.0'
s.osx.deployment_target = '10.9'
s.tvos.deployment_target = '9.0'
s.watchos.deployment_target = '2.0'

iOS, tvOS, and watchOS are informed by Xcode 10.2's minimums that the GUI allows. macOS is 10.9 because Swift isn't supported with a lower deployment target.

I did not actually test on the old platforms running these versions as that could be a rather complicated endeavor. The key thing is that it compiles correctly with these deployment targets. If users actually have issues with running on those older platform versions, that'll be the most informative to any other changes I'd think.

I did verify functionality on all the latest simulators as well as my mac @ 10.14.

allenhumphreys · 2019-04-17T15:50:54Z

Also wanted to mention there was a lot of conversation about the Pod name being SwiftLogAPI, but the actual module name in code is still Logging which means import Logging in actual source code which aligns with SPM integration method. 👍

weissi · 2019-04-17T16:05:24Z

@weissi Here is a git repo that has a rather large set of Apple targets. It uses a local version of the podspec with the following deployment targets:

Thank you so much! I updated this PR, please check :).

Also wanted to mention there was a lot of conversation about the Pod name being SwiftLogAPI, but the actual module name in code is still Logging which means import Logging in actual source code which aligns with SPM integration method. 👍

I mean we can also name the pod Logging if that's what you're suggesting, that name is still available. @tomerd / @ianpartridge / @ktoso / @tanner0101 ?

ktoso · 2019-04-17T16:19:39Z

A bit hard for me to comment on package naming -- don't know that ecosystem very well... whichever you think works best 👍

allenhumphreys · 2019-04-17T17:21:08Z

In the pods ecosystem, having module names match the pod names is pretty common if it's possible. It actually took me a few minutes to realize I shouldn't be doing import SwiftLogAPI.

shuoli84 · 2019-04-22T02:36:48Z

@weissi I believe it is better to use Logging as package name. It will lock the name to prevent other lib use this general name. Sorry for the late comment.

weissi · 2019-04-23T10:55:13Z

Thanks @shuoli84 . @tomerd / @ianpartridge okay with making the CocoaPod just Logging then?

ianpartridge · 2019-04-23T11:10:09Z

Fine by me. Really hope we don't have to do CocoaPods for very long!

weissi · 2019-04-23T11:17:22Z

@ianpartridge thanks, I updated the PR to use Logging. If @tomerd is happy with this I think I'll pull the trigger and upload it.

tomerd · 2019-04-23T17:31:33Z

no strong feeling here, but is it worth reaching out to the owner of SwiftLog pod and see if he wants to work with us on this

tomerd · 2019-04-23T17:32:29Z

@daltoniam ^^

scripts/build_podspec.sh

Motivation: Users ask for a CocoaPod. Unfortunately, the CocodPod `SwiftLog` is already taken, so I went for `SwiftLogAPI`. Modification: Add a podspec generator. Result: Happier users.

weissi · 2019-04-25T16:52:57Z

@tomerd the SwiftLog pod has already a published version 1.0 so I'm not sure if we should use that (even if we could). What do you propose to go forward here? pod name Logging?

tomerd · 2019-04-25T17:32:06Z

What do you propose to go forward here? pod name Logging?

yes, lets do that

weissi force-pushed the jw-podspec-generator branch from 88452ee to 5741d31 Compare April 15, 2019 10:30

weissi requested a review from tomerd April 15, 2019 10:30

weissi mentioned this pull request Apr 15, 2019

CocoaPods / Carthage support #19

Closed

weissi force-pushed the jw-podspec-generator branch from 5741d31 to 1021e23 Compare April 15, 2019 10:35

weissi added the 🔨 semver/patch No public API change. label Apr 15, 2019

weissi added this to the 1.0.1 milestone Apr 15, 2019

weissi mentioned this pull request Apr 15, 2019

Add a podspec for NIOExtras apple/swift-nio-extras#48

Merged

tomerd reviewed Apr 15, 2019

View reviewed changes

scripts/sanity.sh Show resolved Hide resolved

tomerd reviewed Apr 15, 2019

View reviewed changes

scripts/build_podspec.sh Show resolved Hide resolved

weissi force-pushed the jw-podspec-generator branch from 1021e23 to 6a1a52d Compare April 16, 2019 18:43

weissi requested review from ktoso and tomerd April 16, 2019 18:44

tomerd reviewed Apr 16, 2019

View reviewed changes

Sources/Logging/Logging.swift Outdated Show resolved Hide resolved

weissi force-pushed the jw-podspec-generator branch from 6a1a52d to 7400e10 Compare April 16, 2019 19:43

ktoso reviewed Apr 17, 2019

View reviewed changes

NOTICE.txt Outdated Show resolved Hide resolved

weissi force-pushed the jw-podspec-generator branch from 7400e10 to 1359044 Compare April 17, 2019 08:01

weissi requested review from ktoso and tomerd April 17, 2019 08:02

ktoso approved these changes Apr 17, 2019

View reviewed changes

weissi force-pushed the jw-podspec-generator branch from 1359044 to 0a4743d Compare April 17, 2019 16:03

weissi force-pushed the jw-podspec-generator branch from 0a4743d to 99ea1a1 Compare April 23, 2019 11:16

tomerd reviewed Apr 23, 2019

View reviewed changes

scripts/build_podspec.sh Outdated Show resolved Hide resolved

add a CocoaPods podspec generator

970c1aa

Motivation: Users ask for a CocoaPod. Unfortunately, the CocodPod `SwiftLog` is already taken, so I went for `SwiftLogAPI`. Modification: Add a podspec generator. Result: Happier users.

weissi force-pushed the jw-podspec-generator branch from 99ea1a1 to 970c1aa Compare April 23, 2019 17:41

Merge branch 'master' into jw-podspec-generator

c57839b

Merge branch 'master' into jw-podspec-generator

0965a4b

weissi merged commit 67b2425 into apple:master Apr 30, 2019

tmolitor-stud-tu mentioned this pull request Aug 23, 2023

Add CocoaLumberjackSwiftLogBackend to podspec CocoaLumberjack/CocoaLumberjack#1355

Closed

8 tasks

Conversation

weissi commented Apr 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

larryonoff commented Apr 15, 2019

Uh oh!

weissi commented Apr 15, 2019

Uh oh!

ianpartridge commented Apr 15, 2019

Uh oh!

ktoso commented Apr 15, 2019

Uh oh!

Uh oh!

Uh oh!

weissi commented Apr 16, 2019

Uh oh!

Uh oh!

Uh oh!

ktoso left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

allenhumphreys commented Apr 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weissi commented Apr 17, 2019

Uh oh!

allenhumphreys commented Apr 17, 2019

Uh oh!

allenhumphreys commented Apr 17, 2019

Uh oh!

allenhumphreys commented Apr 17, 2019

Uh oh!

weissi commented Apr 17, 2019

Uh oh!

ktoso commented Apr 17, 2019

Uh oh!

allenhumphreys commented Apr 17, 2019

Uh oh!

shuoli84 commented Apr 22, 2019

Uh oh!

weissi commented Apr 23, 2019

Uh oh!

ianpartridge commented Apr 23, 2019

Uh oh!

weissi commented Apr 23, 2019

Uh oh!

tomerd commented Apr 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomerd commented Apr 23, 2019

Uh oh!

Uh oh!

weissi commented Apr 25, 2019

Uh oh!

tomerd commented Apr 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

weissi commented Apr 15, 2019 •

edited

Loading

ktoso left a comment •

edited

Loading

allenhumphreys commented Apr 17, 2019 •

edited

Loading

tomerd commented Apr 23, 2019 •

edited

Loading