Update proposal SLG-0003 after public review#419
Merged
kukushechkin merged 2 commits intoapple:mainfrom Mar 12, 2026
Merged
Conversation
samuelmurray
commented
Feb 25, 2026
Contributor
Author
|
It was a bit hard to keep track of all the text when I edited the proposal in-place, seeing as much of the previous text wasn’t relevant anymore. I will do a re-read later, but felt like it was better to get the PR up now. |
Contributor
Author
|
@kukushechkin I updated the status, and also changed the implementation link to more properly named PR/branch. However, if you don't mind I would like one day for proof-reading before you merging this. |
kukushechkin
approved these changes
Mar 11, 2026
auto-merge was automatically disabled
March 11, 2026 21:26
Head branch was pushed to by a user without write access
Motivation: The public review of the original proposal (https://forums.swift.org/t/proposal-slg-0003-standardized-error-metadata-via-logger-convenience/84518) is done, and these changes adjust for what was decided on. Modifications: The main difference is to pass Error instances as-is to LogHandlers, rather than serializing it to metadata in Logger.
d5eb05c to
22f93f0
Compare
Contributor
Author
|
@kukushechkin thanks for waiting, made a couple of minor word adjustments. All done now! |
kukushechkin
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The public review of the original proposal
(https://forums.swift.org/t/proposal-slg-0003-standardized-error-metadata-via-logger-convenience/84518) is done, and these changes adjust for what was decided on.
Modifications:
The main difference is to pass Error instances as-is to LogHandlers, rather than serializing it to metadata in Logger.