Make InMemoryLogging available on all platforms#394
Merged
glbrntt merged 2 commits intoapple:mainfrom Dec 4, 2025
Merged
Conversation
glbrntt
reviewed
Dec 4, 2025
Contributor
glbrntt
left a comment
There was a problem hiding this comment.
One nit but LGTM otherwise
glbrntt
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make InMemoryLogging available on all platforms
Motivation:
Users might want to adopt the in memory logger on lower platform versions.
Modifications:
Remove availability annotations by using swift-logs own Lock instead of Mutex
Result:
In memory logger can be used on all platforms that swift-log supports