Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apple/swift-log
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.6.3
Choose a base ref
...
head repository: apple/swift-log
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.6.4
Choose a head ref
  • 10 commits
  • 12 files changed
  • 6 contributors

Commits on Mar 31, 2025

  1. Enable macOS CI on merge to main and daily timer (#357)

    Motivation:
    
    * Improve test coverage
    * Check test pass/fail status
    * Monitor CI throughput
    
    Modifications:
    
    Enable macOS CI to be run on all merges to main and on a daily timer.
    
    Result:
    
    Improved test coverage run out-of-band at the moment so we can get a
    feeling for if any changes need to be made in the repo or in the CI
    pipelines to ensure timely and stable checks.
    rnro authored Mar 31, 2025
    Configuration menu
    Copy the full SHA
    222bf1b View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2025

  1. Enable macOS CI on pull requests (#358)

    Motivation:
    
    * Improve test coverage
    
    Modifications:
    
    Enable macOS CI to be run on pull request commits and make the use of
    the nightly runner pool for main.yml jobs explicit.
    
    Result:
    
    Improved test coverage.
    rnro authored Apr 1, 2025
    Configuration menu
    Copy the full SHA
    765db8b View commit details
    Browse the repository at this point in the history
  2. Android test fixes (#356)

    marcprux authored Apr 1, 2025
    Configuration menu
    Copy the full SHA
    748d1eb View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2025

  1. Add static SDK CI workflow (#355)

    Add static SDK CI workflow which runs on commits to PRs, merges to main
    and daily on main.
    rnro authored Apr 2, 2025
    Configuration menu
    Copy the full SHA
    09c99dd View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2025

  1. Enable Swift 6.1 jobs in CI (#359)

    Motivation:
    
    Swift 6.1 has been released, we should add it to our CI coverage.
    
    Modifications:
    
    Add additional Swift 6.1 jobs where appropriate in main.yml,
    pull_request.yml
    
    Result:
    
    Improved test coverage.
    rnro authored Apr 14, 2025
    Configuration menu
    Copy the full SHA
    81d3d07 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2025

  1. Remove inaccurate code comment (#349)

    Remove an inaccurate comment from the code.
    
    ### Motivation:
    
    The removed comment incorrectly described the `flush()` method as not
    having an effect when the flush mode is set to `.always`. Not only is
    this the opposite of the actual behavior, in fact the method itself is
    not affected by the flush mode at all; that check is made elsewhere.
    Further, at the point where the check is made, the behavior is clearly
    spelled out by the code making the check, so moving the comment there
    seems redundant. As such, it seemed best to simply remove it altogether.
    
    ### Modifications:
    
    Removed a comment.
    
    ### Result:
    
    The inaccurate comment can no longer cause confusion.
    
    Co-authored-by: Franz Busch <f.busch@apple.com>
    gwynne and FranzBusch authored Jul 8, 2025
    Configuration menu
    Copy the full SHA
    2281e43 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2025

  1. Overhaul README and documentation catalog to introduce best practic…

    …es (#363)
    
    # Motivation
    
    `SwiftLog` was created before DocC existed which meant that most of the
    documentation was part of the `README` and we had a pretty bare bones
    documentation catalog. We also have a second source of guidelines from
    the SSWG. This results in a currently unsatisfying developer experience
    where everyone has to go around looking for the content in mostly
    undocumented places.
    
    # Modifications
    
    This PR overhauls the `README` and moves most of the content into the
    documentation catalog. It also introduces a new section called "Best
    practices" that are intended to replace the logging guides on swift.org
    so that the content moves closer to where it belongs. To showcase such a
    best practice this PR brings over the log level recommendation of
    swift.org. The recommendation is mostly the same except that after
    recent discussions we wanted to allow libraries to log at `info` level
    when they encounter problems which they can't communicate through other
    channels e.g. by throwing from a method.
    
    # Result
    
    With this PR we provide a nicer experience to our developers making it
    easier for them to get started and understand how to properly log. We
    also set ourselves up for expanding on the best practices around
    logging.
    FranzBusch authored Jul 9, 2025
    Configuration menu
    Copy the full SHA
    c05d672 View commit details
    Browse the repository at this point in the history
  2. Add an article how to implement a log handler (#364)

    # Motivation
    
    In my previous PR, I overhauled the README and the DocC catalog. While
    doing this I removed the guidance around how to implement a log handler.
    
    # Modifications
    
    This PR adds a DocC based guide containing the contents of the previous
    README guidance.
    
    # Result
    
    Guidance around log handler implementation in a modern DocC format.
    FranzBusch authored Jul 9, 2025
    Configuration menu
    Copy the full SHA
    cbd28c2 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2025

  1. Configuration menu
    Copy the full SHA
    e1600be View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2025

  1. remove superfluous whitespace (#366)

    ### Motivation:
    
    `StreamLogHandler` has at some point in time acquired an extra
    whitespace:
    
    ```
    2025-07-18T10:09:12+0100 notice label : hello
                                         ^
                                         |
                                         this one is superfluous
    ```
    
    but we don't typically put spaces in front of `:`s. This PR changes it
    to
    
    ```
    2025-07-18T10:09:12+0100 notice label: hello
                                         ^
                                         |
                                         no extra space
    ```
    
    Additionally, if the label is empty (`""`), then we shouldn't print any
    spaces there. So with an empty label, we go from
    
    ```
    2025-07-18T10:09:12+0100 notice  : hello
                                   ^^
                                    |
                                    two superfluous spaces
    ```
    
    to
    
    ```
    2025-07-18T10:09:12+0100 notice: hello
                                   ^
                                   |
                                   no extra spaces
    ```
    
    
    
    ### Modifications:
    
    - Remove superfluous space if label is not empty
    - Remove two superfluous spaces if label is empty
    
    ### Result:
    
    - Somewhat more compact output
    - Nicer output
    weissi authored Jul 18, 2025
    Configuration menu
    Copy the full SHA
    ce592ae View commit details
    Browse the repository at this point in the history
Loading