containertool: Arrange options into related groups#128
Merged
euanh merged 9 commits intoapple:mainfrom May 12, 2025
Merged
Conversation
Collaborator
Author
|
|
heckj
reviewed
May 7, 2025
Collaborator
heckj
left a comment
There was a problem hiding this comment.
I'm concerned I may have inadvertently been inconsistent. I tend to lean into "container image" vs. "image". I think 'destination' may be a bit overused, but it's super helpful where there's possible confusion of "where I'm getting a base image from" vs. "where I'm sending the built image" - take a look and see what you think. Hopefully this resonates well.
Sources/swift-container-plugin/Documentation.docc/build-container-image.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Joseph Heck <j_heck@apple.com>
…ner-image.md Co-authored-by: Joseph Heck <j_heck@apple.com>
Co-authored-by: Joseph Heck <j_heck@apple.com>
Co-authored-by: Joseph Heck <j_heck@apple.com>
Co-authored-by: Joseph Heck <j_heck@apple.com>
Co-authored-by: Joseph Heck <j_heck@apple.com>
Collaborator
Author
|
Thank you @heckj! |
heckj
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Arranging related options together in groups makes it easier for users to find relevant options. This will be even more beneficial as more options are added (e.g. #91).
Modifications
containertool's command line options into related groups with headings.build-container-imagemanual page to match the new groupings.Result
Test Plan