[CI] Build with the Android SDK and run the tests in the Android x86_64 emulator#140
[CI] Build with the Android SDK and run the tests in the Android x86_64 emulator#140czechboy0 merged 2 commits intoapple:mainfrom
Conversation
|
Thanks @finagolfin - I kicked off the CI. Please also add the same job to the Main workflow. |
|
I wanted to make sure the PR workflow worked well first before adding it to the main branch workflow, will do that next. |
a8703d8 to
2a5e7cf
Compare
|
I went back to only adding Android SDK testing in this pull, but we are seeing flakes 30-40% of the time with this new Android emulator testing workflow, so no problem with waiting to merge this while Marc tinkers with the workflow in swiftlang/github-workflows#223. |
|
Another workflow pull added a small sleep period, can you run the tests again? |
### Motivation Previously, due to overriding the commands to `--product Configuration` we weren't actually building with the Musl SDK. ### Modifications Correctly repeat the Musl SDK triple as well as the extra argument, `--swift-sdk x86_64-swift-linux-musl --product Configuration`. ### Result CI will correctly run for Musl now. Credit to @finagolfin for [finding](#140 (comment)) this. ### Test Plan PR CI.
…64 emulator ### Modifications Enabled CI using the official swiftlang workflow for the Android SDK snapshots ### Result Make sure Android keeps building and working, resolves apple#113. ### Test Plan Will check this PR's result
|
@marcprux pushed a possible Android workflow fix, please run this CI again. |
|
It looks like we'll need to wait for swiftlang/github-workflows#223 (comment) to be merged before the emulator launch fix can be tested. |
|
Alright, Justice merged the polling fix, ready for another CI run. |
|
New CI all passed, ready for review. |
czechboy0
left a comment
There was a problem hiding this comment.
This is great, thank you @finagolfin! 🙏
|
@finagolfin Actually, would you be interested in opening one more PR that updates the supported platforms in the README.md and in Sources/Configuration/Documentation.docc/Documentation.md, reflecting the Android support and which NDK versions? |
|
Sure, I'll take a look. 👍 |
Modifications
Enabled CI using the official swiftlang workflow for the Android SDK snapshots
Result
Make sure Android keeps building and working, resolves #113.
Test Plan
Will check this PR's result