[SortedSet] Fix subtreeCount inconsistency after remove at index#502
Merged
lorentey merged 1 commit intoapple:mainfrom Aug 12, 2025
Merged
[SortedSet] Fix subtreeCount inconsistency after remove at index#502lorentey merged 1 commit intoapple:mainfrom
lorentey merged 1 commit intoapple:mainfrom
Conversation
Previously, when removing an element from a child node, the subtreeCount of the current internal node wasn't updated, leading to incorrect counts.
Member
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where calling
remove(at:)on aSortedSetwould correctly remove the element but fail to update the set’scount, leading to inconsistency between the actual contents and the reported size of the set.The root cause was a missing update to the internal B-Tree node’s
subtreeCountwhen removing an element from a node's child node. This PR ensures the internal node properly decrements itssubtreeCountafter removal, keeping the tree metadata consistent.Resolves #441
Checklist