[BigString] Fix character indexing operations#485
Merged
lorentey merged 2 commits intoapple:release/1.2from Jun 23, 2025
Merged
[BigString] Fix character indexing operations#485lorentey merged 2 commits intoapple:release/1.2from
lorentey merged 2 commits intoapple:release/1.2from
Conversation
BigString sometimes miscounted distances in its character view due to alignment issues. Resolve this by overhauling distance calculations in the character metric: - Introduce a `prefixSize` function in `_StringMetric`, distinct from `distance`. - In the metric-agnostic index distance algorithm, use `prefixCount` to avoid double-counting characters that cross (or end on) chunk boundaries. - Simplify `_StringMetric.distance` by requiring that `start <= end`. - Crucially, change character-index operations to start by rounding each input index down to the nearest character break.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BigStringsometimes miscounts distances in its character view due to alignment issues.Resolve this by overhauling distance calculations in the character metric:
prefixSizefunction in_StringMetric, distinct fromdistance.prefixCountto avoid double-counting characters that cross (or end on) chunk boundaries._StringMetric.distanceby requiring thatstart <= end.rdar://153412693
Checklist