Optimize unspecialized OrderedSet.init and OrderedSet.firstIndex(of:)#433
Merged
lorentey merged 2 commits intorelease/1.2from Nov 22, 2024
Merged
Conversation
6da4419 to
9d3c30e
Compare
Member
Author
9d3c30e to
4b1c4c0
Compare
Member
Author
lorentey
approved these changes
Nov 18, 2024
Member
lorentey
left a comment
There was a problem hiding this comment.
Thanks! 👍 I moved some where clauses to match our coding style.
Member
|
@swift-ci test |
Member
|
I think we'll want to ship this in 1.2.0; would you mind rebasing this on top of release/1.2, rather than main? |
7888030 to
2709b96
Compare
Member
Author
|
Sure! Rebased onto |
Member
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


I have noticed that OrderedSet performance is slower than Dictionary if the
Elementisn't known at compile time and therefore the compiler can't specialize the implementations.This PR replaces some of the generic functions that are generic with manual partial specialized variations that are only generic over the
Elementtype.Checklist