[Build] Use SWIFT_SYSTEM_NAME rather than just lowercasing.#421
Merged
lorentey merged 1 commit intoapple:release/1.1from Sep 23, 2024
Merged
Conversation
Contributor
Author
|
@swift-ci Please test |
This was referenced Sep 18, 2024
Closed
lorentey
reviewed
Sep 20, 2024
Member
lorentey
left a comment
There was a problem hiding this comment.
This looks good, thanks!
We need PR to land on the release/1.1 branch, not main. Can you please retarget it?
Lowercasing `CMAKE_SYSTEM_NAME` to find the name Swift uses for a platform is not guaranteed to work. Instead, use the `SWIFT_SYSTEM_NAME` variable, which lets us override the name when building the Static SDK for Linux. Fixes apple#420.
8c0f4ba to
fec5a5a
Compare
Contributor
Author
Done. |
Contributor
Author
|
@swift-ci Please test |
etcwilde
approved these changes
Sep 23, 2024
Contributor
Author
|
@swift-ci Please test macOS platform |
lorentey
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lowercasing
CMAKE_SYSTEM_NAMEto find the name Swift uses for a platform is not guaranteed to work. Instead, use theSWIFT_SYSTEM_NAMEvariable, which lets us override the name when building the Static SDK for Linux.Fixes #420.