[concurrency] conform Deque.Iterator to unchecked-Sendable#414
Merged
glessard merged 2 commits intoapple:release/1.1from Aug 20, 2024
Merged
[concurrency] conform Deque.Iterator to unchecked-Sendable#414glessard merged 2 commits intoapple:release/1.1from
glessard merged 2 commits intoapple:release/1.1from
Conversation
Contributor
Author
|
@swift-ci please test |
lorentey
reviewed
Aug 20, 2024
5a1457f to
ff11253
Compare
Contributor
Author
|
@swift-ci please test |
ff11253 to
f83b5d7
Compare
f83b5d7 to
73f45ac
Compare
lorentey
approved these changes
Aug 20, 2024
Contributor
Author
|
@swift-ci please test |
lorentey
requested changes
Aug 20, 2024
Member
lorentey
left a comment
There was a problem hiding this comment.
The source file removal needs to be reflected in CMakeLists.txt and Xcode/Collections.xcodeproj
lorentey
approved these changes
Aug 20, 2024
Contributor
Author
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a toolchain that contains swiftlang/swift#75782 (79bf5d51ca4b55afdb29102f411898d78cbe0bf2),
Dequeno longer compiles in Swift 6 mode.extension Deque._Storage: @unchecked Sendable {}makes it compile, though it may not be the best solution?Addresses rdar://134300306
Checklist