Reduce the size of the _FoundationCollections toolchain module#395
Merged
jmschonfeld merged 1 commit intoapple:release/1.1from Jul 8, 2024
Merged
Conversation
d2bb146 to
36d5362
Compare
lorentey
approved these changes
Jun 26, 2024
Member
lorentey
left a comment
There was a problem hiding this comment.
Reluctant thumbs up! Did enabling response files not work right?
Contributor
Author
|
Spoke offline but unfortunately this was the simplest solution that unblocks the swift-foundation work at the moment, I wasn't able to immediately get the response files working but I'll followup to see if we can update to that approach in a later PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The number of object files in the single _FoundationCollections toolchain module was causing issues on Windows by surpassing the maximum command line invocation length. To work around this for now, we reduce the size of the module by not including certain sub-modules. This will unblock the swift-foundation re-core work. At a later time, we could come back to adjust the CMake build to use response files to avoid a large command line invocation if necessary as a full solution.
Checklist