Install the Foundation toolchain module during the static swift build#391
Merged
jmschonfeld merged 1 commit intoapple:release/1.1from Jun 18, 2024
Merged
Conversation
lorentey
approved these changes
Jun 18, 2024
Contributor
Author
|
The toolchain build at https://ci.swift.org/job/swift-PR-toolchain-Linux/873 has confirmed that this no longer poses an issue with the static swift build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the cmake build (specifically the single-module, foundation toolchain build section) to install the
_FoundationCollections.alibrary for the static swift build (but not install it for the non-static build). This ensures the library is present in the static swift SDK in the toolchain (as needed) but not in the standard directory. The usage of this module is still guarded by the-allowable-clientflag written into the swift module.Checklist