add support for riscv64#390
add support for riscv64#390futurejones wants to merge 1 commit intoapple:mainfrom futurejones:add-riscv64-support
Conversation
|
@lorentey any progress? |
lorentey
left a comment
There was a problem hiding this comment.
Sure!
The caveat is that we cannot guarantee that the code will continue to work as is on this architecture -- we don't have CI set up for RISC-V, nor capacity to manually run tests on it.
|
Did you intentionally target this PR on the |
|
@lorentey in the other parts of the swift project I have always submitted PR's to the |
|
Yes. Changes in this repository need to land in the earliest release branch that wants to ship them. The project maintainer then merges (not cherry-picks, merges) them to downstream branches as needed. This is explained in the README. |
|
@lorentey, apologies, I should have read the README more closely. |
|
@futurejones Do you no longer need this change, or were you just unable to retarget it on the release/1.1 branch? |
|
@lorentey I don't have write access to this repository so I can't edit and retarget the PR target branch.
After waiting for nearly 2 months with no response I decided to close the PR rather get stuck in a frustrating cycle of pinging and getting no response. This is what I have been experiencing with other PR's that I have been trying to get approved in several other swift sub projects. Whether or not this PR gets approved and merged is not for my need or benefit, it was to improve the swift project support for everyone. anyway, thanks for responding. |
|
@futurejones I see. I can rebase your commit on top of release/1.1 for you if you want. I have no way to verify that the result will work though, and I strongly suspect the CMake change is not going to be enough. The swift-collections codebase includes a handful of cases where Swift code is conditional on the target architecture, and none of those know about |
Add support for
riscv64as host architecture.Checklist