Skip to content

Fix the incorrect file name in OrderedCollections cmake file#377

Merged
lorentey merged 1 commit intoapple:release/1.1from
iCharlesHu:charles/fix-ordered-collections-cmake
May 22, 2024
Merged

Fix the incorrect file name in OrderedCollections cmake file#377
lorentey merged 1 commit intoapple:release/1.1from
iCharlesHu:charles/fix-ordered-collections-cmake

Conversation

@iCharlesHu
Copy link
Copy Markdown
Contributor

@iCharlesHu iCharlesHu commented May 22, 2024

Currently OrderedCollections cmake incorrectly list "Utilities/_UnsafeBitSet.swift" instead of "Utilities/_UnsafeBitset.swift", causing build failures

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

@iCharlesHu
Fix the incorrect file name in OrderedCollections cmake file
89b3ca0 
- Currently OrderedCollections cmake incorrectly list "Utilities/_UnsafeBitSet.swift" instead of "Utilities/_UnsafeBitset.swift", causing build failures
@iCharlesHu iCharlesHu requested a review from lorentey as a code owner May 22, 2024 02:26
@lorentey lorentey added this to the 1.1.1 milestone May 22, 2024
@lorentey lorentey linked an issue May 22, 2024 that may be closed by this pull request
CMake configuration is broken on case sensitive filesystems #376
Closed
@lorentey lorentey self-assigned this May 22, 2024
lorentey
lorentey approved these changes May 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Charles! 👍

@lorentey
Copy link
Copy Markdown
Member

lorentey commented May 22, 2024

@swift-ci test

@lorentey lorentey merged commit 28161fc into apple:release/1.1 May 22, 2024
@lorentey lorentey mentioned this pull request May 22, 2024
Closed
@jmschonfeld jmschonfeld mentioned this pull request May 22, 2024
Closed
@iCharlesHu iCharlesHu deleted the charles/fix-ordered-collections-cmake branch May 22, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lorentey lorentey lorentey approved these changes

Assignees

@lorentey lorentey

Labels

None yet

Projects

None yet

Milestone

1.1.1

Development

Successfully merging this pull request may close these issues.

CMake configuration is broken on case sensitive filesystems

2 participants

@iCharlesHu @lorentey