Skip to content

Rename RopeModule to _RopeModule in CMakeLists.txt to match Package.swift#373

Merged
lorentey merged 1 commit intoapple:release/1.1from
iCharlesHu:charles/cmake-rename-rope-module
Apr 30, 2024
Merged

Rename RopeModule to _RopeModule in CMakeLists.txt to match Package.swift#373
lorentey merged 1 commit intoapple:release/1.1from
iCharlesHu:charles/cmake-rename-rope-module

Conversation

@iCharlesHu
Copy link
Copy Markdown
Contributor

This PR renames RopeModule defined in CMakeLists.txt to _RopeModule, matching the one defined in Package.swift.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

(All uncompleted tasks are not applicable to this PR)

@iCharlesHu iCharlesHu requested a review from lorentey as a code owner April 30, 2024 18:32
@iCharlesHu
Copy link
Copy Markdown
Contributor Author

@swift-ci please test

Copy link
Copy Markdown
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@lorentey lorentey merged commit fdc7c92 into apple:release/1.1 Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants