[Heap] Add methods to replace minimum/maximum (redux)#208
Merged
lorentey merged 11 commits intoapple:mainfrom Oct 12, 2022
Merged
[Heap] Add methods to replace minimum/maximum (redux)#208lorentey merged 11 commits intoapple:mainfrom
lorentey merged 11 commits intoapple:mainfrom
Conversation
AFAIK, the previous code had no tests for itself, so the revised code doesn't either.
Remove the initializer's own unit tests, assuming that it will always work instead.
If the format of the incoming data does not match that of a heap, a precondition error is flagged instead.
We do not need a _raw initializer in the Heap implementation. The heapify algorithm will not modify storage if it’s already in the expected shape, so we can simply define one locally that double checks that the order remains unchanged.
Member
Author
|
@swift-ci test |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is reviving #116, eliminating all but the actual method implementations.
I still very much doubt that these will ever be used in actual practice, but I'm weary of asking for demonstrable use cases, so I'd much rather close the book on this PR and move on to working on documenting and/or benchmarking this data structure.
Cc @CTMacUser
Checklist