Persistent collections updates (part 10)#207
Merged
lorentey merged 4 commits intoapple:mainfrom Oct 14, 2022
Merged
Conversation
This sanitizes the semantics of _Node.Builder, removing the (unneccessary) need to pass around hash paths. It also slightly refactors removal operations, but stops short of implementing node shrinking. # Conflicts: # Sources/PersistentCollections/Node/_Node+Builder.swift # Sources/PersistentCollections/Node/_Node+Initializers.swift # Sources/PersistentCollections/Node/_Node+Structural intersection.swift # Sources/PersistentCollections/Node/_Node+Structural subtracting.swift # Sources/PersistentCollections/Node/_Node+Subtree Modify.swift # Sources/PersistentCollections/Node/_Node+Subtree Removals.swift # Sources/PersistentCollections/PersistentDictionary/PersistentDictionary+Initializers.swift # Sources/PersistentCollections/PersistentSet/PersistentSet+SetAlgebra Initializers.swift # Sources/PersistentCollections/PersistentSet/PersistentSet+SetAlgebra intersection.swift # Sources/PersistentCollections/PersistentSet/PersistentSet+SetAlgebra subtracting.swift
# Conflicts: # Sources/PersistentCollections/Node/_Node+Primitive Removals.swift
Member
Author
|
@swift-ci test |
Member
Author
|
@swift-ci test |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly about internal cleanups, including a revision of
_Node.Buildersemantics, and some work on simplification/unification of removals. I'm still a bit unhappy about the implementation differences between the in-place mutating and copy-returning variants, but this does make things a little bit better.Checklist