Skip to content

Fix rethrows position#187

Merged
lorentey merged 1 commit intoapple:release/1.0from
ensan-hcl:patch-1
Oct 9, 2022
Merged

Fix rethrows position#187
lorentey merged 1 commit intoapple:release/1.0from
ensan-hcl:patch-1

Conversation

@ensan-hcl
Copy link
Copy Markdown
Contributor

@ensan-hcl ensan-hcl commented Sep 29, 2022

Minor typo fix: Move rethrows before allow.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

@ensan-hcl ensan-hcl requested a review from lorentey as a code owner September 29, 2022 06:29
@lorentey lorentey changed the base branch from main to release/1.0 September 30, 2022 00:59
@lorentey lorentey changed the base branch from release/1.0 to main September 30, 2022 01:00
lorentey
lorentey approved these changes Sep 30, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you!

@lorentey
Copy link
Copy Markdown
Member

lorentey commented Sep 30, 2022

@ensan-hcl It would make sense to include this in the next bug fix release (1.0.4). Would you mind rebasing your branch on release/1.0 instead of main? (I'll then make sure the commit gets forwarded to release/1.1 and main in followup work.)

(It's also no big deal if you can't easily do that -- just let me know & I'll simply land it on main & cherry pick it to release/1.0 instead.)

@lorentey lorentey added this to the 1.0.4 milestone Sep 30, 2022
@ensan-hcl
Fix rethrows position
0f92943 
Minor typo fix.
@ensan-hcl
Copy link
Copy Markdown
Contributor Author

ensan-hcl commented Oct 3, 2022

I updated the branch!

@lorentey lorentey changed the base branch from main to release/1.0 October 9, 2022 20:11
@lorentey
Copy link
Copy Markdown
Member

lorentey commented Oct 9, 2022

@swift-ci test

@lorentey lorentey merged commit 8bf9206 into apple:release/1.0 Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lorentey lorentey lorentey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.4

Development

Successfully merging this pull request may close these issues.

2 participants

@ensan-hcl @lorentey