Add 2 index arguments to custom shell completion calls#763
Merged
natecook1000 merged 3 commits intoMay 7, 2025
Conversation
They indicate to the Swift custom completion function: 1. the word for which completions are being requested. 2. the location of the cursor within that word. Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Collaborator
Author
|
@natecook1000 This is the last of my completed PRs. The next one would be for ToolInfoV0 (#758), but that can only be a draft because I think ToolInfoV0 must be updated for completions to be based on it. I will look into #761 & try to resolve it soon. Other issues remain with the completions, but all shells should be in a better state than before. |
natecook1000
reviewed
May 7, 2025
natecook1000
left a comment
Member
There was a problem hiding this comment.
Looks great! I verified locally that the deprecation messages are coming through properly. 👍🏻
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Collaborator
Author
|
@natecook1000 Pushed a spacing fix using |
Member
|
@swift-ci Please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 2 index arguments to custom shell completion calls.
They indicate to the Swift custom completion function:
Resolve #757
Checklist