Skip to content

Remove extraneous space in shell custom completion calls#762

Merged
natecook1000 merged 1 commit into
apple:mainfrom
rgoldberg:756-excise-space
May 7, 2025
Merged

Remove extraneous space in shell custom completion calls#762
natecook1000 merged 1 commit into
apple:mainfrom
rgoldberg:756-excise-space

Conversation

@rgoldberg

Copy link
Copy Markdown
Collaborator

Remove extraneous space in shell custom completion calls.

Resolve #756

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg

Copy link
Copy Markdown
Collaborator Author

@natecook1000 After this PR is merged, I'll submit my PR for #757 that's ready.

Assuming I fix #761 quickly, I will then submit a PR for that.

After that (or before, if it takes a bit to make a PR for #761), I'll submit a draft PR for #758 so you, @rauhul and/or whoever can look it over to help make completions work based on ToolInfoV0.

@natecook1000

Copy link
Copy Markdown
Member

@swift-ci Please test

@natecook1000 natecook1000 merged commit cb5670a into apple:main May 7, 2025
24 checks passed
@rgoldberg rgoldberg deleted the 756-excise-space branch May 7, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove extraneous space from custom completion calls in all supported shells

2 participants