extend ToolInfoV0 with command visibility#669
Conversation
| /// Extended description of the command's functionality. | ||
| public var discussion: String? | ||
| /// Command should appear in help displays. | ||
| public var shouldDisplay: Bool |
There was a problem hiding this comment.
can you add = true as a fall back for older json generated before this option was introduced?
There was a problem hiding this comment.
Updated now - apologies for the delay, didn't have my laptop with me for the past week. Updated and rebased to resolve conflicts.
rauhul
left a comment
There was a problem hiding this comment.
small change needed, otherwise looks good
- resolves apple#668 by extending the ToolInfoV0 (help dump) struct to include visibility information for commands (already exists for arguments). - updates test output to verify existing examples extend with the additional key.
4e8636c to
6652f22
Compare
|
@swift-ci test |
|
Thanks @rauhul - I missed one piece in the rebasing I think, just made a further commit to line that up properly, so next round should sail through CI without issue.. I hope. Locally verified, anyway. |
|
@swift-ci Please test |
|
Sorry for the last minute nit pick, can we add a test case that results in We can update |
|
@rauhul Sure, can definitely do that. |
|
I've updated the existing test - command |
|
ship it! |
|
@swift-ci test |
Checklist