Skip to content

Fix Repeat's default endless printing#432

Closed
KthKuang wants to merge 0 commit intoapple:mainfrom
KthKuang:main
Closed

Fix Repeat's default endless printing#432
KthKuang wants to merge 0 commit intoapple:mainfrom
KthKuang:main

Conversation

@KthKuang
Copy link
Copy Markdown
Contributor

@KthKuang KthKuang commented Mar 24, 2022

To prevent newbies from being scared off by endless printing in the terminal, I changed the default value of Repeat.count from .max to 2.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@KthKuang KthKuang changed the title Fix Repeat's unstoppable printing Fix Repeat's endless printing Mar 24, 2022
@KthKuang KthKuang changed the title Fix Repeat's endless printing Fix Repeat's default endless printing Mar 24, 2022
@rauhul
Copy link
Copy Markdown
Collaborator

rauhul commented Mar 25, 2022

@swift-ci please test

@rauhul rauhul requested review from natecook1000 and rauhul March 25, 2022 01:27
Copy link
Copy Markdown
Collaborator

@rauhul rauhul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable change to me

@KthKuang KthKuang closed this Mar 27, 2022
@KthKuang KthKuang mentioned this pull request Mar 27, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants